fix: correctly clean up when using the Android back button to dismiss #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the Android back button to dismiss the dialog, we were not running the same cleanup code that we run when pressing the X close button. This is now changed and it caused the Android status bar to re-appear when using the back button. Closes #15
justinlettau
reviewed
Aug 3, 2022
justinlettau
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using the Android back button to dismiss the dialog, we were not
running the same cleanup code that we run when pressing the X close button.
This is now changed and it caused the Android status bar to re-appear
when using the back button.
Closes #15
Type
Breaking Changes
Does this pull request introduce any breaking changes?